Make firmware updating more foolproof#469
Merged
JF002 merged 6 commits intoInfiniTimeOrg:developfrom Jul 22, 2021
Riksu9000:foolproof_update
Merged
Make firmware updating more foolproof#469JF002 merged 6 commits intoInfiniTimeOrg:developfrom Riksu9000:foolproof_update
JF002 merged 6 commits intoInfiniTimeOrg:developfrom
Riksu9000:foolproof_update
Conversation
JF002
reviewed
Jul 22, 2021
Collaborator
JF002
left a comment
JF002
left a comment
There was a problem hiding this comment.
Thanks for this PR! I've just tested the code, the only thing I would add is this small change to prevent the user from closing the app with a swipe on the display.
I've even been able to restart an OTA after a failed one, which was not working previously, awesome :+1 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the firmware update screen not exitable by the user. The screen closes automatically if an error occurs.
Added precautions to make sure the device doesn't sleep during firmware update.
Fixed bugs like State not resetting on error, and BleFirmwareUpdateFinished message being pushed before the Validated state was set.
Fixes #316