Set correct refresh times for LVGL#488
Merged
JF002 merged 1 commit intoInfiniTimeOrg:developfrom Jul 14, 2021
Riksu9000:fix_lvgl_regression
Merged
Set correct refresh times for LVGL#488JF002 merged 1 commit intoInfiniTimeOrg:developfrom Riksu9000:fix_lvgl_regression
JF002 merged 1 commit intoInfiniTimeOrg:developfrom
Riksu9000:fix_lvgl_regression
Conversation
Collaborator
|
This issue with the dropdown in the metronome app is weird... None of the changes from these PRs we done in this app... It's probably caused by a side effect of these changes... I'll merge this PR, but feel free to open a new one if you (or someone else) find a solution for the Metronome! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging both #470 and #482, a new issue came up. LVGL would refuse to refresh in sync with displayapp, causing lag in some cases.
Here I fixed this issue by setting the refresh times in LVGL to 20ms.
The behaviour of the arc in Metronome has also changed with all these changes,
but it should be as intended now.EDIT: There is still one more regression. In metronome, the dropdown menu can't be scrolled. Every value can still be reached by reopening the menu.