Remove unnecessary C-style casts with BLE UUIDs#524
Merged
JF002 merged 1 commit intoInfiniTimeOrg:developfrom Oct 9, 2021
Merged
Remove unnecessary C-style casts with BLE UUIDs#524JF002 merged 1 commit intoInfiniTimeOrg:developfrom
JF002 merged 1 commit intoInfiniTimeOrg:developfrom
Conversation
Instead of casting the UUID object to the ble_uuid_t* used throughout the NimBLE API just pass the address of the ble_uuid_t member that's at the start of each of the UUID structs.
Member
|
I kind of dislike how its just .u ...it feels ambiguous. Any reason to not change it to .uuid? Otherwise i do feel this is much clearer to read compared to before |
Contributor
Author
|
These types are from NimBLE so you'd have to take that up with them. |
Collaborator
|
Very likely that if you'd make a PR that refactors it for niceness it will be merged, @geekbozu. The name has misled more than one person by now so why not try. |
Avamander
approved these changes
Oct 3, 2021
Collaborator
Avamander
left a comment
Avamander
left a comment
There was a problem hiding this comment.
I think it's a good change, both style and safety wise. The current casts are not great.
Collaborator
I totally agree! @jonvmey Thanks for this PR, and sorry for the delay to review it ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of casting the UUID object to the ble_uuid_t* used throughout
the NimBLE API just pass the address of the ble_uuid_t member that's at
the start of each of the UUID structs.