Skip to content

Move PineTimeStyle settings up#636

Merged
JF002 merged 1 commit intoInfiniTimeOrg:developfrom
Itai-Nelken:move-about-firmware-settings-down
Sep 11, 2021
Merged

Move PineTimeStyle settings up#636
JF002 merged 1 commit intoInfiniTimeOrg:developfrom
Itai-Nelken:move-about-firmware-settings-down

Conversation

@Itai-Nelken
Copy link
Copy Markdown
Contributor

It's now over the 'Firmware' entry. It make sense to have 'Firmware' and 'About' the 2 last entries as they are the least used in my opinion.

@JF002 JF002 added this to the 1.5.0 milestone Sep 2, 2021
@JF002
Copy link
Copy Markdown
Collaborator

JF002 commented Sep 2, 2021

Yup, that makes sense!

We could probably use this opportunity to think about how we'll handle the settings of other apps/watchface : should we add a new setting app for each app and watchface, or should the apps/watchface handle their settings by themselves?

@JF002 JF002 mentioned this pull request Sep 2, 2021
@Itai-Nelken
Copy link
Copy Markdown
Contributor Author

Itai-Nelken commented Sep 2, 2021

I think that a single 'Watchface settings' entry that contains settings for the current watchface is a good idea. That way settings won't get cluttered with entries.

Maybe apps can have their own settings menu by swiping left from the watchface or making them sub-menus under 'app settings' in settings?

@0x1a8510f2
Copy link
Copy Markdown

For the time being, I think the PineTimeStyle settings should probably be just under the watch face settings so it's closer to related settings.

@kieranc
Copy link
Copy Markdown
Contributor

kieranc commented Sep 6, 2021

I'm going to try integrate the settings with the watchface in a way that can be extended to the other watchfaces - the current idea is that a long press on the watchface will make a settings icon appear for a few seconds, if you tap the icon it opens the settings. I don't want to just make long press open settings directly as I'm concerned it'll be triggered by accident.

@JF002
Copy link
Copy Markdown
Collaborator

JF002 commented Sep 11, 2021

@kieranc That might be a good idea! It would be nice if you could do a quick PoC to seet what it looks like!

@JF002 JF002 merged commit 2c83c35 into InfiniTimeOrg:develop Sep 11, 2021
@Itai-Nelken Itai-Nelken deleted the move-about-firmware-settings-down branch September 24, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants