Paddle: compare ballX coordinate with horizontal resolution#655
Merged
JF002 merged 1 commit intoInfiniTimeOrg:developfrom Oct 16, 2021
Merged
Paddle: compare ballX coordinate with horizontal resolution#655JF002 merged 1 commit intoInfiniTimeOrg:developfrom
JF002 merged 1 commit intoInfiniTimeOrg:developfrom
Conversation
Riksu9000
approved these changes
Sep 10, 2021
NeroBurner
force-pushed
the
paddle_hor_fix
branch
3 times, most recently
from
4567956 to
5c6849a
Compare
Fix the comment as the comparison checks if the ball is at the right side of the screen. Compare the x coordinate of the ball with the horizontal resolution of the screen, instead of the vertical resolution. On the PinePhone this does make no difference as we have square 240x240 screen. Change it anyways to be completely correct.
NeroBurner
force-pushed
the
paddle_hor_fix
branch
from
5c6849a to
7cd4929
Compare
Contributor
Author
|
rebased on current develop branch |
geekbozu
approved these changes
Oct 12, 2021
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the comment as the comparison checks if the ball is at the right
side of the screen.
Compare the x coordinate of the ball with the horizontal resolution of
the screen, instead of the vertical resolution. On the PinePhone this
does make no difference as we have square 240x240 screen. Change it
anyways to be completely correct.