Add python packages click and cryptography to build instructions#657
Merged
JF002 merged 1 commit intoInfiniTimeOrg:developfrom Oct 22, 2021
Merged
Add python packages click and cryptography to build instructions#657JF002 merged 1 commit intoInfiniTimeOrg:developfrom
JF002 merged 1 commit intoInfiniTimeOrg:developfrom
Conversation
Avamander
requested changes
Sep 10, 2021
Collaborator
Avamander
left a comment
Avamander
left a comment
There was a problem hiding this comment.
Should be a reference to the actual dependency list of mcuboot's tools instead.
Generally documentation is not the way to handle dependencies.
Contributor
Author
|
@Avamander I added the reference, hope it is better this way |
Collaborator
|
Better. But |
Contributor
Author
|
updated, please review |
The script `tools/mcuboot/imgtool/main.py` imports the python packages `click` and `cryptography` to create the target `pinetime-mcuboot-app`. Add it tothe build instructions, as it was not installed on my system. https://github.com/JF002/InfiniTime/blob/6f9f0e8b0e42a5526d47ca664534fb6b0ccb6ace/tools/mcuboot/imgtool/main.py#L19 https://github.com/JF002/InfiniTime/blob/6f9f0e8b0e42a5526d47ca664534fb6b0ccb6ace/tools/mcuboot/imgtool/keys/__init__.py#L19 Also add the commands to install the python requirements into a python venv virtual environment.
Contributor
Author
|
rebased on current develop branch |
Avamander
approved these changes
Oct 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script
tools/mcuboot/imgtool/main.pyimports the python packagesclickandcryptographyto create the targetpinetime-mcuboot-app.Add it tothe build instructions, as it was not installed on my system.
https://github.com/JF002/InfiniTime/blob/6f9f0e8b0e42a5526d47ca664534fb6b0ccb6ace/tools/mcuboot/imgtool/main.py#L19
https://github.com/JF002/InfiniTime/blob/6f9f0e8b0e42a5526d47ca664534fb6b0ccb6ace/tools/mcuboot/imgtool/keys/__init__.py#L19