Exclude some clang-tidy checks#793
Merged
JF002 merged 1 commit intoInfiniTimeOrg:developfrom Oct 30, 2021
Riksu9000:tidy_warnings
Merged
Exclude some clang-tidy checks#793JF002 merged 1 commit intoInfiniTimeOrg:developfrom Riksu9000:tidy_warnings
JF002 merged 1 commit intoInfiniTimeOrg:developfrom
Riksu9000:tidy_warnings
Conversation
Collaborator
Because you have a lower version in CLI than your editor. |
Avamander
approved these changes
Oct 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first check shows a warning on almost every include. Doesn't seem very helpful.
The second one says to use dynamic_cast, but we can't because we use
-fno-rttiI don't see these warnings when running clang-tidy from CLI, but they're shown in my editor. Not sure why that is, but disabling them should be fine right?
https://clang.llvm.org/extra/clang-tidy/checks/llvmlibc-restrict-system-libc-headers.html
https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines-pro-type-static-cast-downcast.html