Remove some clang-tidy checks#829
Merged
JF002 merged 1 commit intoInfiniTimeOrg:developfrom Nov 28, 2021
Riksu9000:clang-tidy-update
Merged
Remove some clang-tidy checks#829JF002 merged 1 commit intoInfiniTimeOrg:developfrom Riksu9000:clang-tidy-update
JF002 merged 1 commit intoInfiniTimeOrg:developfrom
Riksu9000:clang-tidy-update
Conversation
Avamander
approved these changes
Nov 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a clang update I started seeing a bunch more warnings.
The first one I disabled wants everything to be in __llvm_libc namespace.
https://clang.llvm.org/extra/clang-tidy/checks/llvmlibc-implementation-in-namespace.html
The second one wants member variables to be "initialized in a member initializer of the constructor"
This would mean moving every
lv_label_create(),lv_btn_create()etc. to the initialization list.https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines-prefer-member-initializer.html