task_061026_20 — Contract Follow-ups: DINTaskAuditor Size (#201 A4), Dual-Role Guard (#180), Cross-Model S5 (#193) (Umer Majeed)

[umermjd11]

cc @umeradl. This is the tracking discussion for task_061026_20.

Full spec: Developer/tasks/task_061026_20.md. It lands with the forwarding PR. The source plan is task-plan-051026-1, reviewed in PR #219 (verification, decisions, decisions applied).

Timeline

Oct 6 – Oct 9, 2026 (about 3 working days). Parts A and C can start right away. Part B ships with Part A, as two commits in one PR, so the CI size gate proves both fit.

Parts

Part	Issue	PR	Summary	Estimate
A	#201 Part A item 4	PR 1, commit 1	DINTaskAuditor size review. Four getters with no outside reader become internal (−320 B → 22,398 B). A fold review of the dispute and reassignment paths is required	1 d
B	#180	PR 1, commit 2	Per-address dual-role guard in registerDINAuditor (+102 B), plus the stale DinValidatorStake NatSpec	0.5 d
C	#193	PR 2	Two-level S5: the per-slasher GI ring stays, and a per-validator timestamp ring is added (7 days / threshold 6, placeholders; 0 means off on upgraded proxies)	1.5 d

Decisions (resolved on PR #219)

1. Four getters, with one combined budget. The DINTaskAuditor budget across both tasks is: 22,718 → 22,398 (A) → 22,500 (A+B) → 22,575 B with task_061026_21's every-batch commitment check, a margin of 2,001 B. That's in the warn band but far from the 1,024 B fail line. The ways back out are a fold that actually saves bytes, or dropping Is_testdataCIDs_Assigned.
2. security: dual-role registration allows one operator to control both the auditor filter and T1 aggregator in the same GI #180: per-address guard, with three tests.
3. security: S5 recidivism is per-model, so a validator can spread missed votes across models and never escalate #193: option A, the two-level ring. The MECHANISM_DESIGN.md:87 discrepancy is recorded, not changed.

Interplay

• PR test(adversarial): P3Adversarial.t.sol — task_240926_17 Part 2 #218 (P3Adversarial.t.sol): its Row 6 and Row 11 test_knownGap_… tests flip to test_defended_… in whichever PR lands second.
• task_061026_21 (full-GI alignment) shares DINShared.sol, the DINTaskAuditor ABI and its byte budget. Both specs have a coordination section.
• PR feat(indexer): implement DIN Protocol subgraph — platform + task-level contracts #29 (subgraph) gets an ABI note for the internal getters.

Post progress updates, questions and PR links here. If anything in the spec is unclear or doesn't look right, comment here and cc @umeradl.

🤖 Generated with Claude Code

[umermjd11]

Spec PR: #232. It adds this task's spec, the companion task, and closes task_021026_19.

[umermjd11]

PRs raised:

PR	Covers	Status
#235	Parts A + B (#201 A4, #180)	DINTaskAuditor 22,718 → 21,290 B (3,286 B margin, out of the warn band). Getter trim plus three folds that save bytes; dual-role guard (+102 B). 494 tests pass
#236	Part C (#193)	Two-level S5 (7 days / 6, 0 = off on upgraded proxies), new ValidatorEscalatedS5Global event, S5_GLOBAL_* deploy keys. DinValidatorStake +749 B. 502 tests pass

• PR test(adversarial): P3Adversarial.t.sol — task_240926_17 Part 2 #218's Row 6 and Row 11 known-gap tests are not flipped. Both PR bodies say how to flip them when test(adversarial): P3Adversarial.t.sol — task_240926_17 Part 2 #218 rebases.
• The two PRs conflict on one line of DinValidatorStake.md (adjacent caveats No. 4 and No. 5). Keep both lines; whichever PR merges second rebases.
• ABI note posted on feat(indexer): implement DIN Protocol subgraph — platform + task-level contracts #29.