Skip to content

fix: bump requires-python to >=3.10 to match py-cid floor#14

Merged
umeradl merged 1 commit into
InfiniteZeroFoundation:developfrom
Santiagocetran:fix/pyproject-python-floor
Jun 26, 2026
Merged

fix: bump requires-python to >=3.10 to match py-cid floor#14
umeradl merged 1 commit into
InfiniteZeroFoundation:developfrom
Santiagocetran:fix/pyproject-python-floor

Conversation

@Santiagocetran

@Santiagocetran Santiagocetran commented Jun 25, 2026

Copy link
Copy Markdown

What

Bumps requires-python in pyproject.toml from >=3.9 to >=3.10.

Why

Flagged during the review of #12. dincli depends on py-cid>=0.5.0 (pyproject.toml, dincli/requirements.txt), but py-cid==0.5.0's own metadata requires Python >=3.10 (verified against the PyPI JSON API — info.requires_python == ">=3.10" — and its classifiers list only Python 3.10–3.14). So the project advertised >=3.9 support it does not actually have: a pip install on Python 3.9 would fail to resolve py-cid.

This is a pre-existing inconsistency unrelated to the din-node containerization work in #12, so it's split out here as its own one-line fix per review guidance.

Scope

  • One line in pyproject.toml. No code or behavior change.
  • The din-node image already runs Python 3.12, so it is unaffected.

py-cid 0.5.0 metadata (PyPI JSON / wheel METADATA) specifies
requires_python >=3.10 and classifiers only list Python 3.10-3.14.
The project advertised >=3.9 support it does not actually have.

@umeradl umeradl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch from the #12 review. The fix is correct: py-cid==0.5.0 declares requires_python >= '3.10' in its PyPI metadata, so our >=3.9 floor was never achievable. One-line, no behavior change, clean commit message. LGTM.

@umeradl umeradl merged commit 45976b2 into InfiniteZeroFoundation:develop Jun 26, 2026
umeradl added a commit that referenced this pull request Jul 1, 2026
Mark Python version pin fix (P3-BUG2) as done, reflecting completion in commit 45976b2 (PR #14). The fix bumped `requires-python` from `>=3.9` to `>=3.10` to match py-cid==0.5.0 requirements. Note added that multi-version regression testing remains unverified due to absence of CI workflow in the repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants