Feature request: mp4 support for 360P & 480P videos (BiliBili)

[AngelofMe]

Support 360p & 480p for BiliBili service

[InfinityLoop1308]

Can be fixed but not now. Very low priority.

[AngelofMe]

4 Simple Ways to REDUCE MOBILE DATA Usage - Lifewire
https://www.lifewire.com/ways-to-reduce-mobile-data-usage-575295
Why MOBILE DATA is More EXPENSIVE Than Broadband
https://whatphone.com.au/guide/why-mobile-data-is-more-expensive-than-broadband

[InfinityLoop1308]

related #14

[InfinityLoop1308]

@AngelofMe If you want to take this, feel free to ask related questions in this issue,

[mnyon]

Need help for this issue , I read the code and found that to add video quality option it should change the file BillibiliStreamExtractor and in the getVideoOnlyStreams method.
but I am not sure how to debug ,I want to check the variable value after edit ( I set breakpoints but I found IDEA keep printing Error from file bilibili/ProtobufParse) and not sure how to combine the frontend and extractor to see the result.
sorry for my English and I am not sure this topic should talk at here or better to Email, any suggestion is great helpful.(Thank you)

The error is like this.

[ant:checkstyle] [ERROR] src\main\java\org\schabi\newpipe\extractor\services\bilibili\ProtobufParser.java:32665: Line is longer than 100 characters (found 131). [LineLength]
[ant:checkstyle] [ERROR]  src\main\java\org\schabi\newpipe\extractor\services\bilibili\ProtobufParser.java:32665:105: Name 'inlinePlayerDanmakuSwitch_' must match pattern '^(TAG|DEBUG|[a-z][a-zA-Z0-9]*)$'. [MemberName]
[ant:checkstyle] [ERROR]  src\main\java\org\schabi\newpipe\extractor\services\bilibili\ProtobufParser.java:32671: Line is longer than 100 characters (found 129). [LineLength]
[ant:checkstyle] [ERROR]  src\main\java\org\schabi\newpipe\extractor\services\bilibili\ProtobufParser.java:32683: Line is longer than 100 characters (found 129). [LineLength]
[ant:checkstyle] [ERROR]  src\main\java\org\schabi\newpipe\extractor\services\bilibili\ProtobufParser.java:32687: Line is longer than 100 characters (found 135). [LineLength]
[ant:checkstyle] [ERROR]  src\main\java\org\schabi\newpipe\extractor\services\bilibili\ProtobufParser.java:32688: Line is longer than 100 characters (found 194). [LineLength]
[ant:checkstyle] [ERROR]  src\main\java\org\schabi\newpipe\extractor\services\bilibili\ProtobufParser.java:32695: Line is longer than 100 characters (found 129). [LineLength]
[ant:checkstyle] [ERROR]  src\main\java\org\schabi\newpipe\extractor\services\bilibili\ProtobufParser.java:32698: Line is longer than 100 characters (found 153). [LineLength]
[ant:checkstyle] [ERROR]  src\main\java\org\schabi\newpipe\extractor\services\bilibili\ProtobufParser.java:32703: Line is longer than 100 characters (found 126). [LineLength]
[ant:checkstyle] [ERROR]  src\main\java\org\schabi\newpipe\extractor\services\bilibili\ProtobufParser.java:32703:109: Name 'seniorModeSwitch_' must match pattern '^(TAG|DEBUG|[a-z][a-zA-Z0-9]*)$'. [MemberName]
[ant:checkstyle] [ERROR]  src\main\java\org\schabi\newpipe\extractor\services\bilibili\ProtobufParser.java:32708: Line is longer than 100 characters (found 126). [LineLength]
[ant:checkstyle] [ERROR]  src\main\java\org\schabi\newpipe\extractor\services\bilibili\ProtobufParser.java:32719: Line is longer than 100 characters (found 126). [LineLength]

[InfinityLoop1308]

@mnyon Thanks for your interest for this issue!
bilibili/ProtobufParse is used by the Danmu feature, which is still WIP and may be useless. You can just remove it for now.
Please let me know if you still have any questions.

[InfinityLoop1308]

Also from the log it seems that the problem comes from checkstyle, so you can alternatively try to disable this check. I don't encounter this error using my Android Studio.

[mnyon]

Still get antStyleCheck error.

Tried to find solution,like config checkstyle.xml(seems there is no cush file exist),and ant stylecheck in AndroidStudio(Version: Android Studio Dolphin | 2021.3.1 Patch 1) or delete the file(it would cause more error).

I am tring make the breakpoint working so that I can realize what happend in the code,maybe there is some more directly way to run the code without focus the ant stycheck error?

Is there any more information I can provide to make the question more clealy?

Runtime version:VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.

[mnyon]

By the way,this app is really awesome,makes user focus on what they want but not the advertisement or too much recommendation system content.

[InfinityLoop1308]

It is weird because checkstyle has been disabled. Could you plz post the full error log? You can use pastebin.com or file.io if it is too long.