Validate likes string before parsing to Integer#59
Open
devanfibio wants to merge 1 commit intoInfinityLoop1308:mainfrom
Open
Validate likes string before parsing to Integer#59devanfibio wants to merge 1 commit intoInfinityLoop1308:mainfrom
devanfibio wants to merge 1 commit intoInfinityLoop1308:mainfrom
Conversation
fix: improve likes string parser error handling with validation Add null and empty string validation before parsing likes string. If no digits are found in the processed string, throw a descriptive ParsingException instead of allowing Integer.parseInt() to fail with a cryptic NumberFormatException. This provides clearer error messages that help users understand why parsing failed and improves overall error handling consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add validation to the likes string parser to handle edge cases where no digits are found in the input.
The parser now checks if the processed string is null or empty before attempting to parse it with
Integer.parseInt(). If validation fails, a descriptive ParsingException is thrown instead of allowing a NumberFormatException to propagate.This provides clearer error messages and prevents unexpected exceptions during parsing.
Changes
Utils.removeNonDigitCharacters()into a variableInteger.parseInt()Before
After
Benefits