[algorithm] Convert impulse to force when checking for puncture #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th-skam
added
pr: enhancement
pr: status to review
Collaborator
Author
|
CI is expected to fail since SOFA switched to |
th-skam
force-pushed
the
th-forceThreshold
branch
from
5866dee to
1652d51
Compare
th-skam
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr lambda should be divided by dt.
This is to ease the use of the
punctureForceThresholdin theInsertionAlgorithm.Currently, to initiate puncture, we were getting lambda from the constraint solver and checking whether it exceeds the
punctureForceThresholddefined by the user. This lambda represents an impulse (force times dt). If the user changes dt in their simulation setup, they will need to adjust the force threshold as well.