[algorithm] Adapt to contactDistance parameter in scene#118
Merged
Conversation
th-skam
added
pr: clean
pr: status to review
epernod
approved these changes
May 29, 2026
Contributor
epernod
left a comment
epernod
left a comment
There was a problem hiding this comment.
PR on the ConstraintGeometry has already been merged. Good to go
InfinyTech3D/ConstraintGeometry#24
epernod
added
pr: status ready
th-skam
added
pr: run ci
pr: status to review
Collaborator
Author
CI will tell us |
Collaborator
Author
|
Ok, we burnt some trees for this trivial check |
epernod
added
pr: status ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is about adapting the scenes with the
contactDistanceparameter explicitly. Just a small illustration.It's based on #InfinyTech3D/ConstraintGeometry#24 and the latter should be merged first.
This is what happens without the check in #117:
Screen.Recording.2026-05-29.171832.mp4
This is with the check:
Screen.Recording.2026-05-29.172133.mp4