Skip to content

Conversation

@th-skam
Copy link
Collaborator

@th-skam th-skam commented Jul 15, 2025

This PR:

  1. Renames some components to clean log output
  2. Removes unnecessary loading of CollisionAlgorithm/ConstraintGeometry plugins to suppress redundant warnings. The components of these plugins seems to be registered already.

Closes #12
Must be merged after #19

@th-skam th-skam changed the title [scene] Fix issues with the scene setup [scene] Rename some components - cleaning in the NeedleInsertion scene Jul 15, 2025
@epernod epernod added pr: fix pr: status to review To notify reviewers to review this pull-request labels Jul 15, 2025
Comment on lines 54 to 55
'CollisionAlgorithm',
'ConstraintGeometry'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me those one should stay

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I brought these back into the file. However, there are no calls to any factory registration related functions in the plugins. I think both plugins are somehow registering their components during compilation/linking because my scene launches without loading the plugins.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be because the first time you use it a list.conf with the list of plugin is stored. But normally this one is needed.

color=g_cubeColor,name="volume_visu",template="Vec3d")
volumeVisu.addObject("IdentityMapping")

volumeVisu = volume.addChild("visu")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VolumeVisu is already defined in line 162. It seems to me that the visu should be mapped below the collision model to use only the surface.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use this object to add a wireframe visualization of the tetrahedra and be able to see which ones are traversed by the needle. Once we have a functioning algorithm, it will be removed.
I renamed the python variable though.

th-skam added 2 commits July 16, 2025 11:09
This is a temporary object to visualize the wireframe. It will be removed once we get a working version of the insertion algorithm.
@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 16, 2025
@epernod epernod merged commit e23d7b2 into master Jul 16, 2025
@th-skam th-skam deleted the fix-names branch July 23, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug (minor) pr: fix pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Needle] Rethink naming of scene components

3 participants