-
Notifications
You must be signed in to change notification settings - Fork 4
[scene] Rename some components - cleaning in the NeedleInsertion scene #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 'CollisionAlgorithm', | ||
| 'ConstraintGeometry']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me those one should stay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I brought these back into the file. However, there are no calls to any factory registration related functions in the plugins. I think both plugins are somehow registering their components during compilation/linking because my scene launches without loading the plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be because the first time you use it a list.conf with the list of plugin is stored. But normally this one is needed.
scenes/NeedleInsertion.py
Outdated
| color=g_cubeColor,name="volume_visu",template="Vec3d") | ||
| volumeVisu.addObject("IdentityMapping") | ||
|
|
||
| volumeVisu = volume.addChild("visu") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VolumeVisu is already defined in line 162. It seems to me that the visu should be mapped below the collision model to use only the surface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use this object to add a wireframe visualization of the tetrahedra and be able to see which ones are traversed by the needle. Once we have a functioning algorithm, it will be removed.
I renamed the python variable though.
This is a temporary object to visualize the wireframe. It will be removed once we get a working version of the insertion algorithm.
This PR:
Closes #12
Must be merged after #19