-
Notifications
You must be signed in to change notification settings - Fork 4
[cmake] Use API macro mechanism to export classes #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6026302 to
61ab62c
Compare
61ab62c to
7a96515
Compare
epernod
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. Let's double check with the ci.
|
Not sure whether I should export this one: CollisionAlgorithm/src/CollisionAlgorithm/BaseElement.h Lines 13 to 14 in d758a81
It's an internal container in CollisionAlgorithm/src/CollisionAlgorithm/BaseElement.h Lines 48 to 59 in d758a81
We have to export this in such a case right? |
If you think it should be accessible from outside, for exemple form a thrid party library or plugin, yes you need to add the API macro. Edit: I didn't see it was a template class. The Macro need to be added to the template instantiation only. Like here:
|
Based on #88
Close #91