Add 3D MMS validation: Linear #16
Merged
Merged
Conversation
th-skam
reviewed
May 12, 2026
Collaborator
th-skam
left a comment
There was a problem hiding this comment.
Code works, tested on my side. Thanks to the ready plots, we can verify future changes.
I suggested some changes to re-use SOFA components instead of writing new functionality. Once done, we can move on to the next PR.
…logy (#20) * use SOFA components for the nodal force quadrature computation * fix regular grid topology order
th-skam
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3D manufactured solutions with hexahedra (Q1)