Skip to content

[scripts] A re-write of the benchmarks script#53

Merged
epernod merged 3 commits intoInfinyTech3D:mainfrom
th-skam:th-benchmarkScript
Mar 25, 2026
Merged

[scripts] A re-write of the benchmarks script#53
epernod merged 3 commits intoInfinyTech3D:mainfrom
th-skam:th-benchmarkScript

Conversation

@th-skam
Copy link
Contributor

@th-skam th-skam commented Mar 20, 2026

Existing script was using git branches for the benchmarks. New script is using different scenes. Easier to use.

We can have another one for git changes if we want to automate benchmarking a build although sofa has some tools for that already.

Copy link
Contributor

@epernod epernod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be sure I understood, you are running a scene and compare results against reference file?
It might be useful to merge that work with the Regression scripts no?

@epernod epernod added pr: new feature pr: status to review To notify reviewers to review this pull-request labels Mar 24, 2026
@th-skam
Copy link
Contributor Author

th-skam commented Mar 24, 2026

to be sure I understood, you are running a scene and compare results against reference file? It might be useful to merge that work with the Regression scripts no?

No automatic comparison here. I only substituted the old file that used git branches to run and gather the results.
The git-based approach was faulty because you really had to prepare your branches beforehand and take care to switch branches etc in case of a SOFA crash.
The log output here is better as well.

@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 25, 2026
@epernod epernod merged commit 201857f into InfinyTech3D:main Mar 25, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: new feature pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants