fix: add missing windows docker file#35
Merged
Merged
Conversation
carlosmonastyrski
approved these changes
Oct 14, 2025
Contributor
There was a problem hiding this comment.
Greptile Overview
Summary
This PR restores the missing docker/windows Dockerfile that was accidentally removed in a previous revert. The file is required by .goreleaser-windows.yaml:17 to build Windows Docker images for the CLI.
Key points:
- The Dockerfile uses the minimal
nanoserver:ltsc2022base image, which is appropriate for a Go CLI binary - The entrypoint correctly uses Windows-style path syntax (
C:\\infisical.exe) - The file matches the original implementation from commit 5fdac4a
- This fixes the broken Windows Docker image release pipeline introduced in PR #34
Confidence Score: 5/5
- This PR is safe to merge - it simply restores a required file that was accidentally deleted
- The change is minimal and necessary: it adds back a 3-line Dockerfile that was removed in a previous revert. The file is required by the goreleaser-windows configuration and matches the original implementation. There are no logic changes, security concerns, or potential bugs.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| docker/windows | 5/5 | Added missing Windows Dockerfile with minimal nanoserver base image and correct entrypoint configuration |
Sequence Diagram
sequenceDiagram
participant GH as GitHub Actions
participant GR as GoReleaser
participant DF as docker/windows
participant DH as Docker Hub
Note over GH,DH: Windows Release Pipeline
GH->>GH: Trigger on git tag (v*.*.*)
GH->>GH: Run goreleaser-windows job
GH->>GR: Execute with .goreleaser-windows.yaml
GR->>GR: Build Windows binary (infisical.exe)
GR->>DF: Use dockerfile: docker/windows
DF->>DF: FROM nanoserver:ltsc2022
DF->>DF: COPY infisical.exe
DF->>DF: Set ENTRYPOINT
GR->>DH: Push infisical/cli:X.Y.Z-windows-amd64
GR->>DH: Push infisical/cli:latest-windows-amd64
1 file reviewed, no comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📣
Added missing windows docker file for docker image release.
Type ✨