feat: ssh pam#57
Conversation
Greptile Summary
Confidence Score: 1/5
Important Files Changed
|
|
@greptile review this |
There was a problem hiding this comment.
Additional Comments (1)
-
packages/pam/session/credentials.go, line 84-95 (link)logic: SECURITY: Sensitive credentials stored in memory without explicit zeroing after use.
SSH private keys and passwords remain in memory (lines 89, 87) until garbage collected. If the process memory is dumped or swapped to disk, credentials could be exposed. In Go, strings are immutable and can't be reliably zeroed.
Consider adding explicit cleanup with secure memory handling patterns, or document that operators should prevent core dumps and memory swapping on systems running PAM sessions.
11 files reviewed, 3 comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
Description 📣
This PR adds SSH PAM (Privileged Access Management) support to the Infisical CLI, enabling users to establish SSH sessions through the Infisical Gateway with automatic credential injection and session recording.
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets