Skip to content

Conversation

@maidul98
Copy link
Collaborator

Reverts #3675

@maidul98
Copy link
Collaborator Author

maidul98 commented May 29, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR reintroduces Point-in-Time (PIT) functionality for tracking and managing version history of secrets and folders. The implementation includes comprehensive commit tracking, rollback capabilities, and checkpoint management.

  • Added new database tables and schemas for tracking folder commits, checkpoints, and changes with proper indexing and foreign key constraints in /backend/src/db/migrations/20250505194916_add-pit-revamp-tables.ts
  • Implemented secure permission handling for commit operations with granular read/rollback controls in /backend/src/ee/services/permission/project-permission.ts
  • Added proper actor attribution and metadata tracking for all secret operations through folderCommitService integration in multiple services
  • Potential security concern: The removeTrailingSlash function in /backend/src/ee/routes/v1/pit-router.ts should be reviewed for path traversal vulnerabilities
  • Documentation needed: No clear documentation exists in /docs folder for how customers will discover and use the new PIT features

91 file(s) reviewed, 81 comment(s)
Edit PR Review Bot Settings | Greptile

@maidul98 maidul98 merged commit 210ddf5 into main Jun 9, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants