-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Revert "Revert "feat(PIT): Point In Time Revamp"" #3676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "feat(PIT): Point In Time Revamp"" #3676
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR reintroduces Point-in-Time (PIT) functionality for tracking and managing version history of secrets and folders. The implementation includes comprehensive commit tracking, rollback capabilities, and checkpoint management.
- Added new database tables and schemas for tracking folder commits, checkpoints, and changes with proper indexing and foreign key constraints in
/backend/src/db/migrations/20250505194916_add-pit-revamp-tables.ts - Implemented secure permission handling for commit operations with granular read/rollback controls in
/backend/src/ee/services/permission/project-permission.ts - Added proper actor attribution and metadata tracking for all secret operations through folderCommitService integration in multiple services
- Potential security concern: The
removeTrailingSlashfunction in/backend/src/ee/routes/v1/pit-router.tsshould be reviewed for path traversal vulnerabilities - Documentation needed: No clear documentation exists in /docs folder for how customers will discover and use the new PIT features
91 file(s) reviewed, 81 comment(s)
Edit PR Review Bot Settings | Greptile
frontend/src/pages/secret-manager/CommitsPage/components/CommitHistoryTab/CommitHistoryTab.tsx
Show resolved
Hide resolved
frontend/src/pages/secret-manager/CommitsPage/components/CommitHistoryTab/CommitHistoryTab.tsx
Show resolved
Hide resolved
frontend/src/pages/secret-manager/SecretDashboardPage/components/ActionBar/ActionBar.tsx
Show resolved
Hide resolved
feat(PIT-revamp): snapshot changes for PIT revamp and add docs for ne…
Reverts #3675