Skip to content

Conversation

@bednar
Copy link
Member

@bednar bednar commented Nov 20, 2025

Proposed Changes

This pull request refactors the query methods in InfluxDBClientImpl.java to reduce code duplication when processing query responses into custom data objects.

The most significant change is the explicit closing of the VectorSchemaRoot by onClose(vector::close). Although VectorSchemaRoot is automatically released by the FlightSqlClient, we now close it explicitly to add an extra layer of safety and ensure that all resources are properly freed.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.78%. Comparing base (7692c3b) to head (5f74725).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
- Coverage   86.83%   86.78%   -0.06%     
==========================================
  Files          20       20              
  Lines        1299     1294       -5     
  Branches      215      215              
==========================================
- Hits         1128     1123       -5     
  Misses         81       81              
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jansimonb jansimonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bednar bednar merged commit fbaa907 into main Nov 20, 2025
11 checks passed
@bednar bednar deleted the explictly-close branch November 20, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants