Skip to content

Conversation

@NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Oct 22, 2025

Closes #

Proposed Changes

  • Removing the "nightly" setting in the ".circleci/config.yml" file to use the trigger nightly build setting from the CircleCI app.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.79%. Comparing base (5c8d818) to head (afe5c2d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   69.70%   69.79%   +0.08%     
==========================================
  Files          35       35              
  Lines        2314     2314              
==========================================
+ Hits         1613     1615       +2     
+ Misses        701      699       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@NguyenHoangSon96 NguyenHoangSon96 merged commit 1c2c00c into main Oct 22, 2025
19 checks passed
@NguyenHoangSon96 NguyenHoangSon96 deleted the fix/remove-nightly-in-config-file branch October 22, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants