feat: Add Dedicated DataFrame Methods for Writing and Querying #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dataframes were handled before by the general write command, but not documented and not typechecked. Therefore implemented separate functions for writing and querying dataframes.
lebuni
force-pushed
the
add-specific-pandas-methods
branch
from
7f20d81 to
8e4dcd8
Compare
PR InfluxCommunity#158 introduced a bug writing dataframes. Filtering now the kwargs before forwarding them to lower levels
lebuni
force-pushed
the
add-specific-pandas-methods
branch
from
8e4dcd8 to
bae3905
Compare
bednar
changed the title
Contributor
Author
|
Thanks @bednar for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR introduces dedicated methods for working with DataFrames (write_dataframe() and query_dataframe()), providing a cleaner API with better documentation and type checking compared to the previous approach of using the internal _write_api directly.
Fixes a bug introduced in PR #158 where writing DataFrames would fail with a TypeError.
Checklist