fix: Refresh topics when the user accept notifications#183
Merged
Conversation
tevincent
force-pushed
the
fix-notification-registration
branch
from
282921d to
7b14d5c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the notification-permission onboarding flow to trigger a notifications registration refresh (via NotificationsRegistrationManager) when leaving the permission screen, aiming to ensure notification topics/device registration is up to date after the user responds to the permission prompt.
Changes:
- Schedule
RegisterUserDeviceWorkerviaNotificationsRegistrationManager.scheduleWorkerOnUpdatefromNotificationPermissionScreen. - Wire the worker with
notificationTopicsForUser(...)to compute the latest topic list.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tevincent
force-pushed
the
fix-notification-registration
branch
from
4c756a8 to
cf0c460
Compare
baillyjamy
approved these changes
May 19, 2026
Contributor
|
This PR/issue depends on:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on Infomaniak/android-core#768