feat: Add LICENSES.md listing all third-party libraries#1986
feat: Add LICENSES.md listing all third-party libraries#1986JorisBodin merged 3 commits intomainfrom
Conversation
PR Reviewer Guide 🔍(Review updated until commit b9fb21f)Here are some key observations to aid the review process:
|
JorisBodin
force-pushed
the
copilot/add-licenses-file
branch
from
cc00ec8 to
7d41a43
Compare
|
Persistent review updated to latest commit 7d41a43 |
PR Code Suggestions ✨No code suggestions found for the PR. |
|
@copilot Your commit messages do not follow the commit conventions |
Fixed locally via rebase ( To resolve: a force-push or squash-merge of the PR would clear the non-conforming messages from the history. All commits going forward will follow the convention. |
|
Persistent review updated to latest commit 6420140 |
PR Code Suggestions ✨No code suggestions found for the PR. |
JorisBodin
force-pushed
the
copilot/add-licenses-file
branch
from
6420140 to
2439e1d
Compare
There was a problem hiding this comment.
Pull request overview
Adds a third-party licenses document to the repository and exposes it from the app’s About screen (with localized title strings), so users can access the library/license list directly from settings.
Changes:
- Added
LICENSES.mdcontaining a table of third-party libraries and their licenses. - Added a new “Libraries” row to the About screen that opens the
LICENSES.mdURL. - Added
aboutLibrariesTitlestring across the app’s supported locales.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds the base (English) “Libraries” title string. |
| app/src/main/res/values-da/strings.xml | Adds Danish translation for the new About row title. |
| app/src/main/res/values-de/strings.xml | Adds German translation for the new About row title. |
| app/src/main/res/values-el/strings.xml | Adds Greek translation for the new About row title. |
| app/src/main/res/values-es/strings.xml | Adds Spanish translation for the new About row title. |
| app/src/main/res/values-fi/strings.xml | Adds Finnish translation for the new About row title. |
| app/src/main/res/values-fr/strings.xml | Adds French translation for the new About row title. |
| app/src/main/res/values-it/strings.xml | Adds Italian translation for the new About row title. |
| app/src/main/res/values-nb/strings.xml | Adds Norwegian Bokmål translation for the new About row title. |
| app/src/main/res/values-nl/strings.xml | Adds Dutch translation for the new About row title. |
| app/src/main/res/values-pl/strings.xml | Adds Polish translation for the new About row title. |
| app/src/main/res/values-pt/strings.xml | Adds Portuguese translation for the new About row title. |
| app/src/main/res/values-sv/strings.xml | Adds Swedish translation for the new About row title. |
| app/src/main/res/layout/fragment_settings_about.xml | Adds the new clickable “Libraries” item in the About settings UI. |
| app/src/main/java/com/infomaniak/drive/ui/menu/settings/AboutSettingsFragment.kt | Wires the new row to open the licenses URL. |
| LICENSES.md | Introduces the third-party licenses listing document. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Persistent review updated to latest commit 2439e1d |
PR Code Suggestions ✨No code suggestions found for the PR. |
Co-authored-by: JorisBodin <2796439+JorisBodin@users.noreply.github.com> Agent-Logs-Url: https://github.com/Infomaniak/android-kDrive/sessions/d5d44b9a-554e-4735-ae08-7b0167aada23
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
JorisBodin
force-pushed
the
copilot/add-licenses-file
branch
from
b3d7eea to
b9fb21f
Compare
JorisBodin
changed the title
|
Persistent review updated to latest commit b9fb21f |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
type(optional_scope): Uppercase message(from.github/workflows/semantic-commit.yml)Initial plan→chore: Initial planAdd LICENSES.md and Libraries item to About screen→feat: Add LICENSES.md and Libraries item to About screenfeat: Add translationwas already correct✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.