Skip to content

fix: Fix the formatting of a string so it matches with all of the others#2016

Merged
LunarX merged 1 commit intomainfrom
fix-string-placeholder-format
Apr 30, 2026
Merged

fix: Fix the formatting of a string so it matches with all of the others#2016
LunarX merged 1 commit intomainfrom
fix-string-placeholder-format

Conversation

@LunarX
Copy link
Copy Markdown
Contributor

@LunarX LunarX commented Apr 30, 2026

All other locales had the type "d" instead of "s", only it and es had "s", so I update the format to be coherent

@LunarX LunarX requested a review from solrubado April 30, 2026 09:00
@LunarX LunarX self-assigned this Apr 30, 2026
Copilot AI review requested due to automatic review settings April 30, 2026 09:00
@LunarX LunarX enabled auto-merge April 30, 2026 09:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the trashedFileRestoreFileInSuccess plural string formatting across locales so the “other” quantity uses an integer placeholder (matching the default and other translations), preventing inconsistent format types between languages.

Changes:

  • Update Italian trashedFileRestoreFileInSuccess plural (“other”) from %1$s to %1$d.
  • Update Spanish trashedFileRestoreFileInSuccess plural (“other”) from %1$s to %1$d.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
app/src/main/res/values-it/strings.xml Makes the “other” plural formatting consistent by using an integer placeholder for the item count.
app/src/main/res/values-es/strings.xml Makes the “other” plural formatting consistent by using an integer placeholder for the item count.
Comments suppressed due to low confidence (1)

app/src/main/res/values-it/strings.xml:730

  • In the Italian trashedFileRestoreFileToOriginalPlaceSuccess plural, the other string contains a typo (ipristinati). This will be user-visible in bulk restore-to-origin flows; please correct it to ripristinati.
        <item quantity="other">%1$d elementi ripristinati in %2$s</item>
    </plurals>
    <plurals name="trashedFileRestoreFileToOriginalPlaceSuccess">
        <item quantity="one">%s ripristinato nell’ubicazione di origine</item>
        <item quantity="other">%d elementi ipristinati nell’ubicazione di origine</item>

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link
Copy Markdown

@LunarX LunarX merged commit c3440d1 into main Apr 30, 2026
12 checks passed
@LunarX LunarX deleted the fix-string-placeholder-format branch April 30, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants