Make sure the model name is always lowcase#37
Merged
InftyAI-Agent merged 1 commit intoInftyAI:mainfrom Apr 25, 2026
Merged
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
Member
Author
|
/lgtm |
InftyAI-Agent
added
needs-triage
InftyAI-Agent
removed
the
do-not-merge/needs-kind
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure model names are consistently lowercased when invoking the Hugging Face downloader, improving cache/registry consistency for user-provided model IDs.
Changes:
- Lowercase the model name before calling
download_model()in thepullCLI flow (Hugging Face provider). - Expand the README installation section to include
cargo installand add a more detailed “build from source” walkthrough.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/cli/commands.rs |
Lowercases pull model argument before invoking the Hugging Face download path. |
README.md |
Updates installation instructions (Cargo install + source build steps). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?