Merged
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
Member
Author
|
/kind documentation |
InftyAI-Agent
added
needs-triage
There was a problem hiding this comment.
Pull request overview
This PR appears to consolidate the project’s logo assets by removing older/unused logo files and updating the README to point at the new canonical light/dark SVGs under site/images/.
Changes:
- Added new
site/images/logo-{light,dark}.svgassets. - Removed older logo SVG variants under
docs/images/. - Updated
README.mdheader logo<picture>sources to reference the new SVGs.
Reviewed changes
Copilot reviewed 1 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
site/images/logo-light.svg |
Adds the light-theme SVG logo asset intended for README/site usage. |
site/images/logo-dark.svg |
Adds the dark-theme SVG logo asset intended for README/site usage. |
README.md |
Updates the README’s <picture> logo references to the new assets. |
docs/images/logo-light3.svg |
Removes an older logo SVG variant. |
docs/images/logo-light2.svg |
Removes an older logo SVG variant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4
to
+6
| <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/InftyAI/PUMA/main/site/images/logo-dark.svg"> | ||
| <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/InftyAI/PUMA/main/site/images/logo-light.svg"> | ||
| <img alt="PUMA Logo" src="https://raw.githubusercontent.com/InftyAI/PUMA/main/site/images/logo-light.svg" width="240"> |
There was a problem hiding this comment.
The README logo references raw.githubusercontent.com/.../main/..., which hard-pins rendering to the main branch and the upstream repo. This breaks logo rendering in forks, in non-main branches/PR previews, and when browsing the repo offline. Prefer repo-relative paths (e.g., site/images/logo-dark.svg / site/images/logo-light.svg) so the README renders consistently from the current checkout.
Suggested change
| <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/InftyAI/PUMA/main/site/images/logo-dark.svg"> | |
| <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/InftyAI/PUMA/main/site/images/logo-light.svg"> | |
| <img alt="PUMA Logo" src="https://raw.githubusercontent.com/InftyAI/PUMA/main/site/images/logo-light.svg" width="240"> | |
| <source media="(prefers-color-scheme: dark)" srcset="site/images/logo-dark.svg"> | |
| <source media="(prefers-color-scheme: light)" srcset="site/images/logo-light.svg"> | |
| <img alt="PUMA Logo" src="site/images/logo-light.svg" width="240"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?