add make lint and make test#8
Merged
Merged
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR adds repository-level lint/test automation and introduces Python unit tests for the SandD server API.
Changes:
- Adds
make lintand expandsmake testto run Rust and Python tests. - Adds a new GitHub Actions workflow for lint/test CI.
- Adds Python server tests and minor formatting/lint cleanups.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
Makefile |
Adds Ruff linting and expands test commands across Rust and Python. |
.github/workflows/rust-ci.yaml |
Adds CI jobs that call the new Make targets. |
python/tests/test_server.py |
Adds unit tests for the Python Server wrapper. |
python/tests/__init__.py |
Marks the Python tests package. |
server/src/server.rs |
Removes unused imports. |
server/src/protocol.rs |
Removes an unused import. |
sandd/src/main.rs |
Applies formatting/lint cleanups. |
examples/agent_example.py |
Removes an unnecessary f-string. |
.github/workflows/kube-workflow-init.yaml |
Whitespace-only formatting update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: kerthcet <kerthcet@gmail.com>
Member
Author
|
/lgtm |
Member
Author
|
/triage accepted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?