Feature/eig 616 review UI barcodescan productdetails#42
Conversation
… all the dependent flags to that. update AuthController to derive the sign‑in provider from Supabase user.identities (with a safe fallback to appMetadata["provider"]), then wire signedInWithApple, signedInWithGoogle, signedInAsGuest, and currentSignInProviderDisplay to that single source of truth so the Settings screen always shows the correct provider.
Replaced arrow-right asset images and updated references. Added new feedback and star rating image assets. Refactored UserFeedbackCard to include a selectable star rating UI and feedback image. Updated YourBarcodeScans to display dynamic scan count from UserPreferences and refresh on appear. Enhanced UserPreferences to track and refresh total scan count. Modified BarcodeDataCard to increment scan count only on successful product analysis. Improved ArrowSwipeShimmer opacity handling in BarcodeScanCameraControls.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Deleted an extraneous 'matching' line from the UserFeedbackCard view to clean up the code and prevent potential confusion.
|
@ codex review |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // Reset scan counter after showing prompt | ||
| successfulScanCount = 0 | ||
| totalScanCount = 0 | ||
| UserDefaults.standard.set(successfulScanCount, forKey: UserPreferences.successfulScanCountKey) |
There was a problem hiding this comment.
recordRatingPrompt() zeroes both successfulScanCount and the new totalScanCount, and both properties persist via successfulScanCountKey (lines 132‑137). That means whenever a rating prompt is recorded, the user-facing “Scans completed” total in YourBarcodeScans drops back to 0 even though lifetime scans should keep accumulating. The reset happens immediately after a prompt is shown.
Useful? React with 👍 / 👎.
2 participants
No description provided.