Fix/remove pysha3 dependency #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sha3. Removed also the use of pysha3 directly. This will allow the SDK to work with Python 3.11
…ectiveLabs/sdk-python into fix/remove_pysha3_dependency
… safe-pysha3 does not work with Python <=3.8)
achilleas-kal
approved these changes
Jun 6, 2023
… messages from the Explorer. The transaction response message structure changed in the last chain upgrade. The messages in the transaction are now included in the messages attribute instead of the data attribute
…released to master
…ion_responses_v046 fix/adapt code to transaction responses v046
…preparation for next release
Release/staging v064
…8s` anymore (that node has been removed in favor of the load balanced nodes)
…innet_node Fix/remove k8s as valid mainnet node
Fix/sync dev with master 065
…sha3. Removed also the use of pysha3 directly. This will allow the SDK to work with Python 3.11
… safe-pysha3 does not work with Python <=3.8)
…ectiveLabs/sdk-python into fix/remove_pysha3_dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pysha3library. That library is not compatible with Python 3.11 and is no longer maintained. It was replaced with the librarysafe-pysha3.eip712-struct, because that library requirespysha3. It was replaced by the libraryeip712.IMPORTANT NOTE:
The new library to have keccak hash algorithm (simple-pysha3) only works for Python >= 3.9. That means that the library from the moment we merge this PR will no longer be compatible with Python 3.7 or 3.8. Users willing to use those Python versions will have to stick to SDK version 0.6.3.2 (the last one released)