fix/update_creation_msg_liquidate_position #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aarmoa
commented
Jan 18, 2024
aarmoa
commented
- Updated the logic to create the MsgLiquidatePosition message
- Added a example script on how to broadcast a MsgLiquidatePositions message
…ew example script on how to broadcast a MsgLiquidatePosition
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #296 +/- ##
=======================================
Coverage 72.97% 72.97%
=======================================
Files 48 48
Lines 3404 3404
Branches 303 303
=======================================
Hits 2484 2484
Misses 839 839
Partials 81 81 ☔ View full report in Codecov by Sentry. |
nicolasbaum
approved these changes
Jan 18, 2024
nicolasbaum
left a comment
nicolasbaum
left a comment
There was a problem hiding this comment.
Change looks good. Addition of optional argument for liquidator order allows full usage of message fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.