Skip to content

fix(readme): align function signatures, Comparable type, and search sort requirement with actual implementation#55

Merged
Ink01101011 merged 2 commits into
feature/change-readme-to-use-kksort-webfrom
copilot/sub-pr-54
Mar 13, 2026
Merged

fix(readme): align function signatures, Comparable type, and search sort requirement with actual implementation#55
Ink01101011 merged 2 commits into
feature/change-readme-to-use-kksort-webfrom
copilot/sub-pr-54

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 13, 2026

README had several inaccuracies relative to the actual TypeScript definitions and runtime behavior.

Fixes:

  • Comparable type: Added missing bigint and object to match src/utils/index.ts; notes now clarify that object requires a custom compareFn since defaultCompare throws for it
  • Function signatures: Replaced bare sortFn<T>(...) / searchFn<T>(...) (invalid TS) with declare function syntax
  • Search sort requirement: Narrowed overly broad "must pre-sort before Search" note — only binarySearch and jumpSearch require a sorted array; linearSearch and quickSearch work on unsorted input
  • Spacing: Fixed Types usedโดยTypes used โดย

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

…earch sort requirement note

Co-authored-by: Ink01101011 <181562170+Ink01101011@users.noreply.github.com>
Copilot AI changed the title [WIP] Update README to provide Thai-language usage reference fix(readme): align function signatures, Comparable type, and search sort requirement with actual implementation Mar 13, 2026
Copilot AI requested a review from Ink01101011 March 13, 2026 04:27
@Ink01101011 Ink01101011 marked this pull request as ready for review March 13, 2026 04:30
@Ink01101011 Ink01101011 merged commit bf4daab into feature/change-readme-to-use-kksort-web Mar 13, 2026
@Ink01101011 Ink01101011 deleted the copilot/sub-pr-54 branch March 13, 2026 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants