Conversation
更新所有相关文件和引用,从 Hardcodet.Wpf.TaskbarNotification 迁移到 H.NotifyIcon 调整通知显示方式并添加 ForceCreate 调用确保图标正确显示 Signed-off-by: doudou0720 <98651603+doudou0720@users.noreply.github.com>
This reverts commit bad05f7.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fea6576dfb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| private void InitializeNavigationMenu() | ||
| { | ||
| // 自动将插件页面添加到导航菜单 | ||
| foreach (var pluginPage in _pluginPages) |
There was a problem hiding this comment.
Guard plugin page iteration when plugin load fails
If ./Plugins is missing or MEF composition throws, LoadPluginSettingsPages catches the exception and leaves _pluginPages unset, but InitializeNavigationMenu immediately does foreach (var pluginPage in _pluginPages). In that common no-plugin environment this throws a NullReferenceException during SettingsWindow2 construction, so opening the new settings window crashes instead of degrading gracefully.
Useful? React with 👍 / 👎.
| public static class Strings | ||
| { | ||
| private const string EmbeddedEnUsResxName = "Ink_Canvas.Properties.Strings.enUS.xml"; | ||
| private const string EmbeddedEnUsResxName = "Ink_Canvas.Properties.Strings.en-US.resx"; |
There was a problem hiding this comment.
Restore a valid embedded source for English fallback map
GetString uses GetManifestResourceStream + ResXResourceReader to provide a shared fallback for all en* cultures, but this constant now points to Strings.en-US.resx, which is not available as a raw manifest .resx stream in the main assembly after the project-item changes. That leaves the map empty, so locales like en-GB/en-AU no longer get English strings and fall back to neutral Chinese resources.
Useful? React with 👍 / 👎.
No description provided.