Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the visual styling and layout of the header section to improve spacing, alignment, and accessibility. The main focus is on improving line heights for better readability and repositioning the GitHub link as a styled element within the header.
Key Changes:
- Adjusted line-height values from compressed (0.8, 0.85) to more readable values (1, 1.6)
- Repositioned GitHub link from bottom of header to top-right corner with dedicated styling
- Modified header padding to accommodate the repositioned GitHub link
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| index.html | Moved GitHub link element to appear after header main content with added class for styling |
| css/common.css | Updated line-height values, added GitHub link positioning styles, adjusted header padding, and changed flex alignment from justify-content to align-items |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for the contribution @yuhattor! The whole thing is really not optimized for Mobile, I am realizing :) On Desktop the background color changes when hovering over the different days in the calendar. Probably I just choose a default color other than red ;) |
|
Thank you! |
This pull request updates the layout and styling of the main header and related elements to improve visual alignment, spacing, and add a dedicated GitHub link. The changes primarily affect
css/common.cssandindex.html, focusing on header padding, alignment, and the addition of a styled GitHub project link.Visuals
Smartphone
Desktop
Line-height adjustment