Skip to content

Adjusting line height#1

Merged
spier merged 2 commits intomainfrom
adjusting-line-height
Dec 3, 2025
Merged

Adjusting line height#1
spier merged 2 commits intomainfrom
adjusting-line-height

Conversation

@yuhattor
Copy link
Copy Markdown
Member

@yuhattor yuhattor commented Dec 3, 2025

This pull request updates the layout and styling of the main header and related elements to improve visual alignment, spacing, and add a dedicated GitHub link. The changes primarily affect css/common.css and index.html, focusing on header padding, alignment, and the addition of a styled GitHub project link.

Visuals

Smartphone

image

Desktop

image

Line-height adjustment

image

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the visual styling and layout of the header section to improve spacing, alignment, and accessibility. The main focus is on improving line heights for better readability and repositioning the GitHub link as a styled element within the header.

Key Changes:

  • Adjusted line-height values from compressed (0.8, 0.85) to more readable values (1, 1.6)
  • Repositioned GitHub link from bottom of header to top-right corner with dedicated styling
  • Modified header padding to accommodate the repositioned GitHub link

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
index.html Moved GitHub link element to appear after header main content with added class for styling
css/common.css Updated line-height values, added GitHub link positioning styles, adjusted header padding, and changed flex alignment from justify-content to align-items

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread css/common.css
Comment thread css/common.css
Copy link
Copy Markdown
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just try this ;)

@spier spier merged commit 1ea4e21 into main Dec 3, 2025
6 checks passed
@spier spier deleted the adjusting-line-height branch December 3, 2025 15:52
@spier
Copy link
Copy Markdown
Member

spier commented Dec 3, 2025

Thanks for the contribution @yuhattor!

The whole thing is really not optimized for Mobile, I am realizing :)

On Desktop the background color changes when hovering over the different days in the calendar.
On Mobile it sticks to the red color, which makes the text harder to read.

Probably I just choose a default color other than red ;)

@yuhattor
Copy link
Copy Markdown
Member Author

yuhattor commented Dec 5, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants