Skip to content

Conversation

@tsadler1988
Copy link
Collaborator

First pass at scripts for #362.

Before merging, I think we should:

  • Document new site generation steps
  • Refactor this and the old script to de-duplicate common code
  • Use path.join everywhere for cross-platform compatibility

See also InnerSourceCommons/innersourcecommons.org#32, where I've raised rendering issues that need addressing.

@rrrutledge
Copy link
Contributor

Wow this is cool, Tom! I will try to take a look sometime early next week.

@tsadler1988
Copy link
Collaborator Author

Tested the refactor with InnerSourceCommons/innersourcecommons.org#252

@tsadler1988 tsadler1988 marked this pull request as ready for review February 19, 2021 21:39
@tsadler1988 tsadler1988 requested a review from a team as a code owner February 19, 2021 21:39
@tsadler1988
Copy link
Collaborator Author

@rrrutledge this is now ready for review. I've addressed everything except GH Actions and translations, which I think can be tackled separately.

@tsadler1988
Copy link
Collaborator Author

I had a bit of momentum on this, so have progressed on translations for the new website too (see InnerSourceCommons/innersourcecommons.org#52).

@rrrutledge
Copy link
Contributor

Awesome, Tom! I will try for a review this week.

Copy link
Contributor

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good, Tom. Thanks for this work. Had a few questions.

"dirName": "introduction",
"workbook": "01-introduction.asciidoc",
"translations": ["de", "it", "ja", "zh", "ru"],
"image": "images/learn/LP_thumbnail_introduction.jpg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these files in the other repo? I feel like they should be here so as to remove this coupling.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the time the thumbnail is retrieved from YouTube (see https://github.com/InnerSourceCommons/innersourcecommons.net/blob/master/content/learn/learning-path/contributor/01.md for example) - this is just a backup for where there is no video, which is only the workbooks.

I do think we need to choose an image for workbooks, as using intro thumbnails isn't really relevant. I tried rendering the site without images for workbooks but it doesn't really work.

Can we raise an issue for a workbook image separately, and address the coupling at the same time?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the way to resolve the coupling issue would be to move the images to the InnerSourceLearningPath repo and then copy them over to innersourceommmons.org along with the articles - no?

Copy link
Contributor

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you!

@tsadler1988 tsadler1988 merged commit c51ac1a into InnerSourceCommons:master Mar 2, 2021
@tsadler1988 tsadler1988 deleted the new-website-scripts branch March 2, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants