-
Notifications
You must be signed in to change notification settings - Fork 47
New website scripts #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New website scripts #369
Conversation
|
Wow this is cool, Tom! I will try to take a look sometime early next week. |
|
Tested the refactor with InnerSourceCommons/innersourcecommons.org#252 |
|
@rrrutledge this is now ready for review. I've addressed everything except GH Actions and translations, which I think can be tackled separately. |
|
I had a bit of momentum on this, so have progressed on translations for the new website too (see InnerSourceCommons/innersourcecommons.org#52). |
|
Awesome, Tom! I will try for a review this week. |
rrrutledge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really good, Tom. Thanks for this work. Had a few questions.
| "dirName": "introduction", | ||
| "workbook": "01-introduction.asciidoc", | ||
| "translations": ["de", "it", "ja", "zh", "ru"], | ||
| "image": "images/learn/LP_thumbnail_introduction.jpg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these files in the other repo? I feel like they should be here so as to remove this coupling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the time the thumbnail is retrieved from YouTube (see https://github.com/InnerSourceCommons/innersourcecommons.net/blob/master/content/learn/learning-path/contributor/01.md for example) - this is just a backup for where there is no video, which is only the workbooks.
I do think we need to choose an image for workbooks, as using intro thumbnails isn't really relevant. I tried rendering the site without images for workbooks but it doesn't really work.
Can we raise an issue for a workbook image separately, and address the coupling at the same time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the way to resolve the coupling issue would be to move the images to the InnerSourceLearningPath repo and then copy them over to innersourceommmons.org along with the articles - no?
rrrutledge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thank you!
First pass at scripts for #362.
Before merging, I think we should:
See also InnerSourceCommons/innersourcecommons.org#32, where I've raised rendering issues that need addressing.