fixes part of the issue #436 #452
Merged
fioddor merged 15 commits intoInnerSourceCommons:masterfrom Dec 13, 2021
Merged
Conversation
…ion 06-conclusion-artitle-es.asciidoc & 06-conclusion-article-es.md
…ion 06-conclusion-script-es.asciidoc & 06-conclusion-script-es.md
tsadler1988
added
Article
Translation
Collaborator
|
Thanks for this @devGuadalajara! @fioddor @Sergih28 @JFernando122 could any of you give this a review please? |
Collaborator
|
Sorry @devGuadalajara, we spotted that you've translated the scripts which were used for the videos, rather than the articles that appear on the website. The English article file can be found here. |
tsadler1988
reviewed
Oct 25, 2021
6 tasks
Contributor
|
@fioddor may be able to review as a native Spanish speaker? |
fioddor
requested changes
Nov 8, 2021
Collaborator
There was a problem hiding this comment.
Thank you, @devGuadalajara, very much for your contribution! We'd like to fix some issues for better readability, though:
- Some literal translation feel weird.
- Some standards.
- Plus some optional improvement suggestions.
And, please, forgive our delayed response.
6 tasks
fioddor
requested changes
Nov 8, 2021
Collaborator
There was a problem hiding this comment.
I just learned how to code suggestions, which makes your life so much easier and fun. These are just the explicit expansions of a previous general comment.
BTW, feel free to review this translation and take revenge kicking my ass. ;-)
Collaborator
|
Hey @devGuadalajara, did you get a chance to accept or respond to @fioddor's suggestions? |
Contributor
|
If it's a tough time for @devGuadalajara to take a look then another option is to see if another Spanish-speaking contributor can finish out this great work. |
Fix confusing syntactic structure
"Script" is a false friend.
We use to capitalize Contribuidor, as it refers to a specific InnerSource role, beyond the regular meaning of the word.
Too literal translations -word by word- tend to feel weird. It is better to focus on the message and rebuild the syntax from stratch.
We are using the informal form to address the reader. It not only feels more modern and fresh but it also avoids much ambiguity, as the formal one (Usted) derives historically from the third person (Vuestra merced), causing conflicts with other terms in the sentence.
IIRC, we're standardizing on "Contribuidor" instead of "colaborador". In fact "colaborador" sounds actually smoother, but is more ambiguous and we want to stress contribution over collaboration.
I might be over-picky here, but in spanish "discusión" tends to imply (not always) some level of rough conflict, while "debate" is expected to be smooth, educated and respectful.
Standardize on informal, singular form for the second person ("you").
Informal form for addressing the reader.
Reads more natural.
Reads clearer.
We keep only the .asciidoc files.
fioddor
approved these changes
Dec 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added spanish translation 06-conclusion-artitle-es.asciidoc & 06-conclusion-article-es.md