Skip to content

Sloppy translation as baseline for issue 460#470

Merged
rrrutledge merged 4 commits intomasterfrom
i460-fr-trusted-committer-01-intro
Jul 19, 2022
Merged

Sloppy translation as baseline for issue 460#470
rrrutledge merged 4 commits intomasterfrom
i460-fr-trusted-committer-01-intro

Conversation

@fioddor
Copy link
Copy Markdown
Collaborator

@fioddor fioddor commented Apr 23, 2022 •
edited
Loading

Just a sloppy translation as baseline for teasing true french speakers into applying serious corrections. See #460.

@fioddor
Sloppy translation
692fd81 
Just a baseline for serious corrections by true french speakers.
@fioddor fioddor requested a review from a team as a code owner April 23, 2022 08:14
@fioddor
Copy link
Copy Markdown
Collaborator Author

fioddor commented Apr 23, 2022 •
edited
Loading

Please, @SJVle, review.

Don't know why github doesn't allow me to add you as reviewer.

@rrrutledge
Copy link
Copy Markdown
Contributor

rrrutledge commented Apr 23, 2022

why github doesn't allow me

Need to invite the person as a collaborator to the project first.

@SJVle
Copy link
Copy Markdown
Collaborator

SJVle commented Apr 25, 2022 via email

@fioddor
Copy link
Copy Markdown
Collaborator Author

fioddor commented May 9, 2022

@SJVle , I just invited you. Sorry for the delay.

@SJVle
Copy link
Copy Markdown
Collaborator

SJVle commented May 13, 2022 •
edited
Loading

Hi I can't find the file to review... i'm not so used to git :(

@fioddor
Copy link
Copy Markdown
Collaborator Author

fioddor commented May 16, 2022

Hi I can't find the file to review... i'm not so used to git :(

No worries. We can walk you through:

  1. The changes proposed (the new file in this case) are in the last tab of this page (up): "Files changed".
  2. You can then introduce comments to any line. The UI will ask you if you want to start a revision and will relate all comments to that revision until you close it.
  3. When you comment, there's a button that allows you to propose a change to the commented line. It has a similar icon to the "Files changed" tab.
  4. Once you finish adding comments you can close your review by approving/rejecting/requesting to apply your suggested changes. These options are shown when clicking at the green button at the top-right of the files.

@tsadler1988
Copy link
Copy Markdown
Collaborator

tsadler1988 commented Jun 21, 2022

@nysenthil links to English and French as requested:
English
French

@nysenthil
Copy link
Copy Markdown
Collaborator

nysenthil commented Jun 28, 2022

Today, I got help from my IBM colleague (Lionel Villard) here in Yorktown Heights, NY to verify the Engligh to French machine translated text. I'm attaching the output of our verification work here. In the next few days, Travis and I will work to get it in proper form in the pull request so that it can be committed.

01-Introducing-The-Trusted-Committer-Role-English-To-French-Verification.txt

02-Introducing-The-Trusted-Committer-Role-French-Verification.txt

@tjohnson31415
Committing suggested edits from reviewer
d3a86b8 
Not my translations. The content of changes are from the files posted in #470 (comment).

I made minor formatting changes on top of the content changes.
@fioddor fioddor requested a review from nysenthil July 12, 2022 15:51
nysenthil added 2 commits July 13, 2022 14:47
@nysenthil
Update 01-introduction-fr.asciidoc
4962c9a
@nysenthil
Update 01-introduction-fr.asciidoc
3c651c3 
This is the final version that was fully reviewed by a native French speaking IBM colleague Abdoulaye Traore. It is ready for merging into the web page.
@rrrutledge
Copy link
Copy Markdown
Contributor

rrrutledge commented Jul 19, 2022 •
edited
Loading

Thank you @ablocus❗

@rrrutledge
Copy link
Copy Markdown
Contributor

rrrutledge commented Jul 19, 2022

And thank you, @lionelvillard ❗

rrrutledge
rrrutledge approved these changes Jul 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go team 🎉 ❗

@rrrutledge rrrutledge merged commit eda52db into master Jul 19, 2022
@rrrutledge rrrutledge deleted the i460-fr-trusted-committer-01-intro branch July 19, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rrrutledge rrrutledge rrrutledge approved these changes

@nysenthil nysenthil Awaiting requested review from nysenthil

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fioddor @rrrutledge @SJVle @tsadler1988 @nysenthil @tjohnson31415