Merged
Conversation
* Converted from Product section
…ingPath into project-leader
rrrutledge
commented
May 8, 2023
| const workbookReadPath = join('..', 'workbook', section.workbook) | ||
|
|
||
| writeMarkdownFile(workbookFileName, workbookFrontMatter, body) | ||
| if (section.workbook && fs.existsSync(workbookReadPath)) { |
Contributor
Author
There was a problem hiding this comment.
Just check if the workbook exists rather than inferring the same due to the fact of it being a translation. See what you think @tsadler1988.
rrrutledge
commented
May 8, 2023
| "dirName": "project-leader", | ||
| "workbook": "", | ||
| "workbookImage": "", | ||
| "image": "images/learn/LP_thumbnail_projectleader.jpg", |
Contributor
Author
There was a problem hiding this comment.
Needs InnerSourceCommons/innersourcecommons.org#530 merged first for this to work.
MaineC
approved these changes
May 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.