Skip to content

How to create a new Learning Path section#562

Merged
rrrutledge merged 9 commits intomainfrom
rrrutledge-patch-3
Aug 22, 2023
Merged

How to create a new Learning Path section#562
rrrutledge merged 9 commits intomainfrom
rrrutledge-patch-3

Conversation

@rrrutledge
Copy link
Copy Markdown
Contributor

Steps I followed for the Project Leader section.

@rrrutledge rrrutledge requested a review from a team as a code owner June 15, 2023 03:22
Copy link
Copy Markdown
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly reviewed formatting, as I cannot really assess the quality of the content.

Comment thread scripts/README.md Outdated
Comment thread scripts/README.md Outdated
Comment thread scripts/README.md Outdated
Comment thread scripts/README.md Outdated
marshmallowrobot and others added 4 commits August 21, 2023 15:26
Taking @spier's suggested change to numbering format.

Co-authored-by: Sebastian Spier <github@spier.hu>
Taking @spier's suggested spacing change.

Co-authored-by: Sebastian Spier <github@spier.hu>
Taking @spier's suggested spacing changes.

Co-authored-by: Sebastian Spier <github@spier.hu>
Taking @spier's suggested numbering changes.

Co-authored-by: Sebastian Spier <github@spier.hu>
Comment thread scripts/README.md Outdated
Comment thread scripts/README.md Outdated
Comment thread assets/thumbnails/thumbnail_rationale.asciidoc Outdated
Co-authored-by: Laura <935915+marshmallowrobot@users.noreply.github.com>
@rrrutledge
Copy link
Copy Markdown
Contributor Author

Thanks for the reviews! Look good now?

Copy link
Copy Markdown
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread scripts/README.md Outdated
@rrrutledge rrrutledge merged commit c5cd86c into main Aug 22, 2023
@rrrutledge rrrutledge deleted the rrrutledge-patch-3 branch August 22, 2023 14:21
@rrrutledge
Copy link
Copy Markdown
Contributor Author

Thanks for the review, @spier ❗️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants