First draft of the "InnerSource Activity Score" pattern#189
First draft of the "InnerSource Activity Score" pattern#189lenucksi merged 1 commit intoInnerSourceCommons:masterfrom
Conversation
spier
left a comment
There was a problem hiding this comment.
Great job putting this together. I love the relative brevity, the very specific problem you are trying to solve, and with that the immediate applicability of your pattern for other users.
While this example is tied to the use of GitHub somewhat, I would leave it that way, rather than generalizing it to other version control systems. My reasoning for leaving it specific to GitHub:
- many orgs are using GitHub anyways
- the examples provided are indeed specific to GitHub right now. so for other so try to adopt this pattern, this is actually helpful
- during the lifetime of the pattern, other people may translate this pattern to their context. This is how patterns are meant to be used anyways.
- once that pattern adoption by others happens, they can share the specifics of their approach e.g. "this is how we adapted this to work with gitlab instead"
I left a couple of specific comments with suggestions inline, and I hope you find them useful.
For this pattern to be even more useful for others, I would likely invest a little bit more time into the Context and Forces section, as it sounds like there is more that you can say about your setup that even made you "discover" this problem and solution.
|
Thanks, all your feedback has been worked in the most recent commit. |
1 similar comment
|
Thanks, all your feedback has been worked in the most recent commit. |
spier
left a comment
There was a problem hiding this comment.
Awesome job working in the feedback so swiftly @Michadelic!
I made minor suggestions, that are mostly formatting changes and one typo.
With those things fixed, I think this pattern can already be merged to master.
In later iterations we could then work in experiences from other companies, and probably improve the Context and Forces section a bit more.
But as I said, as a first version of this pattern, this is already amazing! 👍
|
Worked some more on the content and added a nice sketch. |
|
Thank you, also from my side, for your contribution @Michadelic :) Looking at the maturity levels for patterns laid out in the contributor handbook, where would you see the proposed pattern? |
lenucksi
left a comment
There was a problem hiding this comment.
This looks excellent, thanks! Happy to merge this, added one comment regarding Acknowledgements and would like to highlight @maxcapraro comment regarding the expected classification (which will need an extra commit once decided).
Regarding the independence of GitHub as a tool: The pull request states the concepts that are embodied by GitHub as an example implementation and lists other alternatives, hence transferring the ideas of this patterns to other implementations should be doable.
Michadelic
left a comment
There was a problem hiding this comment.
Thank you, also from my side, for your contribution @Michadelic :) Looking at the maturity levels for patterns laid out in the contributor handbook, where would you see the proposed pattern?
based on the handbook i would say "2 - Structured", it is currently validated just by one party.
|
Messed up my branch by rebasing the latest structure changes so i did a force push to work in the final version 💯 Kind Regards, |
|
Wow, fantastic work in here everybody. Great stuff! Btw thanks for dealing with the rebasing on top of master. We could not find a less disruptive way of cleaning up our folder structure. Luckily this problem will resolve itself over time and all new PRs won't have this problem anyways. |
|
Thanks for the 💐! |
FINISHED - Thanks for the help!