Skip to content

First draft of the "InnerSource Activity Score" pattern#189

Merged
lenucksi merged 1 commit intoInnerSourceCommons:masterfrom
Michadelic:master
Aug 11, 2020
Merged

First draft of the "InnerSource Activity Score" pattern#189
lenucksi merged 1 commit intoInnerSourceCommons:masterfrom
Michadelic:master

Conversation

@Michadelic
Copy link
Copy Markdown
Contributor

@Michadelic Michadelic commented Jul 31, 2020

FINISHED - Thanks for the help!

Copy link
Copy Markdown
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job putting this together. I love the relative brevity, the very specific problem you are trying to solve, and with that the immediate applicability of your pattern for other users.

While this example is tied to the use of GitHub somewhat, I would leave it that way, rather than generalizing it to other version control systems. My reasoning for leaving it specific to GitHub:

  • many orgs are using GitHub anyways
  • the examples provided are indeed specific to GitHub right now. so for other so try to adopt this pattern, this is actually helpful
  • during the lifetime of the pattern, other people may translate this pattern to their context. This is how patterns are meant to be used anyways.
  • once that pattern adoption by others happens, they can share the specifics of their approach e.g. "this is how we adapted this to work with gitlab instead"

I left a couple of specific comments with suggestions inline, and I hope you find them useful.

For this pattern to be even more useful for others, I would likely invest a little bit more time into the Context and Forces section, as it sounds like there is more that you can say about your setup that even made you "discover" this problem and solution.

Comment thread innersource-activity-score.md Outdated
Comment thread innersource-activity-score.md Outdated
Comment thread innersource-activity-score.md Outdated
Comment thread innersource-activity-score.md Outdated
Comment thread innersource-activity-score.md Outdated
Comment thread innersource-activity-score.md Outdated
Comment thread innersource-activity-score.md Outdated
Comment thread innersource-activity-score.md Outdated
Comment thread innersource-activity-score.md Outdated
Comment thread innersource-activity-score.md Outdated
@Michadelic
Copy link
Copy Markdown
Contributor Author

Thanks, all your feedback has been worked in the most recent commit.
Please have a look again and let me know what else should to be addressed.

1 similar comment
@Michadelic
Copy link
Copy Markdown
Contributor Author

Thanks, all your feedback has been worked in the most recent commit.
Please have a look again and let me know what else should to be addressed.

Copy link
Copy Markdown
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job working in the feedback so swiftly @Michadelic!

I made minor suggestions, that are mostly formatting changes and one typo.

With those things fixed, I think this pattern can already be merged to master.

In later iterations we could then work in experiences from other companies, and probably improve the Context and Forces section a bit more.

But as I said, as a first version of this pattern, this is already amazing! 👍

Comment thread README.md Outdated
Comment thread repository-activity-score.md
Comment thread repository-activity-score.md
Comment thread repository-activity-score.md Outdated
Comment thread repository-activity-score.md
Comment thread repository-activity-score.md Outdated
Comment thread repository-activity-score.md Outdated
Comment thread repository-activity-score.md Outdated
Comment thread repository-activity-score.md Outdated
@Michadelic
Copy link
Copy Markdown
Contributor Author

Worked some more on the content and added a nice sketch.
Will keep this PR open until early next week at least for further feedback

@maxcapraro maxcapraro added the 📖 Type - Content Work Working on contents is the main focus of this issue / PR label Aug 6, 2020
@maxcapraro
Copy link
Copy Markdown
Member

Thank you, also from my side, for your contribution @Michadelic :) Looking at the maturity levels for patterns laid out in the contributor handbook, where would you see the proposed pattern?

Copy link
Copy Markdown
Member

@lenucksi lenucksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent, thanks! Happy to merge this, added one comment regarding Acknowledgements and would like to highlight @maxcapraro comment regarding the expected classification (which will need an extra commit once decided).

Regarding the independence of GitHub as a tool: The pull request states the concepts that are embodied by GitHub as an example implementation and lists other alternatives, hence transferring the ideas of this patterns to other implementations should be doable.

Comment thread repository-activity-score.md Outdated
Copy link
Copy Markdown
Contributor Author

@Michadelic Michadelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, also from my side, for your contribution @Michadelic :) Looking at the maturity levels for patterns laid out in the contributor handbook, where would you see the proposed pattern?

based on the handbook i would say "2 - Structured", it is currently validated just by one party.

Comment thread repository-activity-score.md Outdated
@Michadelic
Copy link
Copy Markdown
Contributor Author

Messed up my branch by rebasing the latest structure changes so i did a force push to work in the final version 💯
Classification set to "2 - structured", can be merged as is from my side, but feel free to check...

Kind Regards,
Michael

@Michadelic Michadelic requested a review from lenucksi August 11, 2020 13:04
@lenucksi lenucksi merged commit 42efe52 into InnerSourceCommons:master Aug 11, 2020
@spier
Copy link
Copy Markdown
Member

spier commented Aug 11, 2020

Wow, fantastic work in here everybody.
From start to finishing in under 2 weeks, and a well structured pattern at the end of this.

Great stuff!

Btw thanks for dealing with the rebasing on top of master. We could not find a less disruptive way of cleaning up our folder structure. Luckily this problem will resolve itself over time and all new PRs won't have this problem anyways.

@Michadelic
Copy link
Copy Markdown
Contributor Author

Thanks for the 💐!

@lenucksi lenucksi added the 1-initial Donuts, Early pattern ideas, ... (Please see our contribution handbook for details) label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1-initial Donuts, Early pattern ideas, ... (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants