Skip to content

fix : Team 승률 null일 때 직관 리포트 NPE 수정 #126#127

Merged
GOOHAESEUNG merged 1 commit intodevfrom
fix/#126/game-report-npe
Mar 2, 2026
Merged

fix : Team 승률 null일 때 직관 리포트 NPE 수정 #126#127
GOOHAESEUNG merged 1 commit intodevfrom
fix/#126/game-report-npe

Conversation

@GOOHAESEUNG
Copy link
Copy Markdown
Contributor

@GOOHAESEUNG GOOHAESEUNG commented Mar 2, 2026

Summary

  • Team.getWinRate()가 null일 때 double 언박싱으로 인한 NullPointerException 수정
  • null인 경우 0.0 기본값 처리

Test plan

  • Team의 winRate가 null인 상태에서 직관 리포트 API 호출 시 정상 응답 확인
  • Team의 winRate가 정상값일 때 기존 동작 유지 확인

Closes #126

Summary by CodeRabbit

릴리스 노트

  • 버그 수정
    • 경기 리포트에서 승률 데이터가 누락된 경우를 안정적으로 처리하도록 개선했습니다. 이제 승률 정보가 없을 때 0.0으로 표시되어 리포트 생성 시 안정성이 향상됩니다.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 2, 2026

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between 32b7d2f and 6a067ac.

📒 Files selected for processing (1)
  • src/main/java/com/inninglog/inninglog/domain/kbo/service/GameReportService.java
 _________________________________________________________________________________________________________________________
< It is better to have 100 functions operate on one data structure than 10 functions on 10 data structures. - Alan Perlis >
 -------------------------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ

✏️ Tip: You can disable in-progress messages and the fortune message in your review settings.

Tip

CodeRabbit can generate a title for your PR based on the changes with custom instructions.

Set the reviews.auto_title_instructions setting to generate a title for your PR based on the changes in the PR with custom instructions.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/#126/game-report-npe

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@GOOHAESEUNG GOOHAESEUNG merged commit 80e3a20 into dev Mar 2, 2026
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix : Team.getWinRate() null로 인한 직관 리포트 NPE 수정

1 participant