[DiscordRPC] Fix RPC showing previous song on Linux#202
Merged
Inrixia merged 2 commits intoInrixia:devfrom Dec 8, 2025
Merged
Conversation
Inrixia
requested changes
Dec 8, 2025
Owner
Inrixia
left a comment
There was a problem hiding this comment.
This looks awesome!
Could you unwrap MediaItem.onMediaTransition
Otherwise is perfect and will merge as soon as that's sorted 💜
Contributor
Author
|
Sure!! It's done :) |
Owner
|
Perfect! Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discord RPC displayed the previous track after a song transition.
This seems to be caused by a race condition between the
TIME_UPDATEandonMediaTransitionevents, combined withasyncDebounce. A delayed, debouncedTIME_UPDATEcould callupdateActivitywith stale data and overwrite the newer info fromonMediaTransition, so Discord ends up showing the previous track.What I changed:
TIME_UPDATEinterception: Discord calculates playback progress locally usingstartTimestamp/endTimestamp, making constant updates unnecessarymediaItemdirectly toupdateActivityinonMediaTransition:Ensures the correct media item is used immediately, avoiding stale data fromfromPlaybackContext()asyncDebounce: No longer needed sinceTIME_UPDATEwas the main source of rapid callsResult:
I tested on Linux and Windows, the plugin seems to work as expected on both. Any feedback is welcome :)