fix: point bin entry to dist/index.js instead of nonexistent bin/insf…#1
Merged
tonychang04 merged 2 commits intomainfrom Feb 25, 2026
Merged
fix: point bin entry to dist/index.js instead of nonexistent bin/insf…#1tonychang04 merged 2 commits intomainfrom
tonychang04 merged 2 commits intomainfrom
Conversation
…orge.js The bin field referenced ./bin/insforge.js which was never created, preventing npm from symlinking the insforge command on install. Since tsup already outputs dist/index.js with the shebang, point bin there directly and remove the unused "bin" entry from the files array. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tonychang04
force-pushed
the
fix/cli-bin-entry
branch
from
fa00aed to
491cc67
Compare
tonychang04
added a commit
that referenced
this pull request
Apr 29, 2026
…ild failure (#91) * fix(cli/compute): write fly.toml stub on fresh apps + roll back on build failure Two bugs in 0.1.60 source-mode deploy that block first-time users: 1. **Missing fly.toml stub.** flyctl on a freshly-created Fly app with zero machines errors with "could not create a fly.toml from any machines :-(". The src/lib/flyctl.ts comment claimed "flyctl will invent a fly.toml if none exists" — that was wrong. flyctl only invents one by introspecting existing machines, of which a brand-new app has zero. Fix: ensureFlyTomlStub() writes a minimal stub (app/primary_region/ internal_port + http_service block) into the user's directory before spawning flyctl, and removes it on exit (success OR failure OR spawn error). If the user already has a fly.toml, leave it untouched — advanced users get full override. 2. **Zombie service on build failure.** Before the fix, a flyctl build error left a half-created service (DB row + empty Fly app, machineId null) that the user had to manually `compute delete`. Reproducible 100% on the first deploy because of bug #1. Fix: deploy.ts catches build failure on a freshly-created service (existing === undefined) and DELETEs the service row through the OSS proxy — which destroys the Fly app too. On redeploy of an existing service we don't roll back: the running machine should survive a transient build error. flyctlBuildAndPush signature gains required region and port for the stub. New tests cover stub creation, the user-fly.toml-respected path, and stub cleanup on every exit path (success / non-zero exit / spawn error). Bumped to 0.1.61. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(cli/compute): eslint curly — wrap rollback-failed log in braces Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CarmenDou
added a commit
that referenced
this pull request
May 2, 2026
- --json mode: print authorize URL to stderr instead of stdout so the final JSON result stays parseable; browser still opens and polling still runs (review #1). - spawn wizard with stdio: 'ignore' on all three streams in --json mode so unconsumed pipes can't block on long wizard output (review #5). - fetchPosthogConnection accepts an optional AbortSignal so polling can cancel a hung request when the deadline or user signal fires (review #3). - All three posthog API fetches go through a fetchWithTimeout helper that gives each request a 30s timeout and respects an optional caller signal (reviews #6, #7).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…orge.js
The bin field referenced ./bin/insforge.js which was never created, preventing npm from symlinking the insforge command on install. Since tsup already outputs dist/index.js with the shebang, point bin there directly and remove the unused "bin" entry from the files array.