Skip to content

fix: filter skill install to only insforge and insforge-cli#13

Merged
tonychang04 merged 1 commit intomainfrom
fix/skill-install-filter
Mar 5, 2026
Merged

fix: filter skill install to only insforge and insforge-cli#13
tonychang04 merged 1 commit intomainfrom
fix/skill-install-filter

Conversation

@tonychang04
Copy link
Contributor

@tonychang04 tonychang04 commented Mar 5, 2026

Summary

  • Added -s insforge -s insforge-cli flags to the npx skills add command in installSkills()
  • Without these flags, all skills from the repo are installed — including skill-creator, which is a dev tool not meant for end users
  • Also updated the fallback warning message with the correct flags

Test plan

  • Verified npx skills add insforge/agent-skills -s insforge -s insforge-cli --list only shows the two InsForge skills

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Improvements
    • The npx skills add command has been enhanced with explicit skill-scoping flags to ensure more accurate and reliable skill installation
    • Error messages have been updated to provide clearer guidance and step-by-step instructions for users who need to perform manual skill installation

Without -s flags, npx skills add installs all skills from the repo
including skill-creator which is a dev tool, not a user-facing skill.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 284ae6e2-5027-4988-854f-feac43476f10

📥 Commits

Reviewing files that changed from the base of the PR and between f3e2698 and 61c6ceb.

📒 Files selected for processing (1)
  • src/lib/skills.ts

Walkthrough

The pull request updates the npx skills add command in src/lib/skills.ts to include explicit skill-scoping flags (-s insforge and -s insforge-cli), specifying which skills are installed. The error message is updated to guide users to use these same flags during manual installation.

Changes

Cohort / File(s) Summary
Skill Installation Configuration
src/lib/skills.ts
Added explicit skill-scoping flags (-s insforge -s insforge-cli) to the npx skills add command and updated error message to include these flags for manual installation guidance.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 A rabbit hops through the code so neat,
Adding flags to make skills complete!
Insforge and insforge-cli, now crystal clear,
Error messages guide, no need to fear. 🎉

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/skill-install-filter

Comment @coderabbitai help to get the list of available commands and usage tips.

@tonychang04 tonychang04 merged commit 65fd76d into main Mar 5, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant