refactor(compute): rename compute logs to compute events#96
Conversation
The OSS endpoint this command calls returns Fly machine lifecycle events (start/stop/exit/restart) — not container stdout/stderr. Calling it `compute logs` was misleading; `compute events` is honest. When real container stdout/stderr lands later, the freshly-vacated `compute logs` command name will be used for actual log streaming. Mild breaking change — `npx`-based usage cache means most users won't notice on the next invocation. Tracks the parallel rename in OSS PR that moves /api/compute/services/:id/logs → /events. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review WalkthroughThis pull request replaces the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 4/5 reviews remaining, refill in 12 minutes. Comment |
Summary
compute logs <id>→compute events <id>. The OSS endpoint behind it returns Fly machine lifecycle events (start/stop/exit/restart), not container stdout/stderr — the new name is honest./api/compute/services/:id/logs→/events. Both must ship together.compute logsfor the future container stdout/stderr feature (roadmap; see OSS spec2026-04-07-compute-dashboard-ux-design.md).Why this is OK as a breaking change
compute logs. Most users invoke vianpxso the next run picks up the rename.compute logsfor actual log streaming later avoids permanent semantic debt.Test plan
npm run lintpasses (149 tests, 13 skipped).npx insforge-cli compute events <id> --limit 5returns the events array (against OSS PR #1062 build).🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes
New Features
compute events <id>command to retrieve compute machine lifecycle events (start, stop, exit, restart) with timestamps and messages. Supports--limit(1–1000, default 50) and--jsonoutput formatting.Breaking Changes
compute logscommand; usecompute eventsinstead.