feat: cleaning all iterations attribute#324
Merged
laurentC35 merged 3 commits intomainfrom Mar 18, 2026
Merged
Conversation
nsenave
reviewed
Mar 18, 2026
Contributor
nsenave
left a comment
nsenave
left a comment
There was a problem hiding this comment.
Quelques commentaires
Toujours bien d'utiliser le wrapper Boolean plutôt que le primitif
Contributor
There was a problem hiding this comment.
on pourrait remplacer les equals et hashcode avec les annotations lombok
ou (mieux) convertir la classe en record si c'est possible
| private boolean isAggregatorUsed; | ||
| private Boolean isAggregatorUsed; | ||
| @JsonProperty(value = "shouldCheckAllIterations") | ||
| private Boolean shouldCheckAllIterations ; |
Contributor
There was a problem hiding this comment.
ça serait bien de mettre une ligne de javadoc pour rappeler l'idée générale derrière cette prop
(pareil pour isAggregatorUsed)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: change
booleantoBoolean(java Object) to ensure backward compatibility