Refactor/concept dto#441
Merged
GtanSndil merged 13 commits intorefactor/refactoring_magma_traditional_in_new_magmafrom Apr 1, 2026
Merged
Refactor/concept dto#441GtanSndil merged 13 commits intorefactor/refactoring_magma_traditional_in_new_magmafrom
GtanSndil merged 13 commits intorefactor/refactoring_magma_traditional_in_new_magmafrom
Conversation
added 6 commits
March 4, 2026 09:42
FBibonne
approved these changes
Mar 27, 2026
| .map(ConceptDTO::transformDTOenDefinition) | ||
| List<ConceptDTO> listConceptDTOsWithLinks = listConceptDTOs.stream() | ||
| .map(conceptDto -> { | ||
| if (Boolean.TRUE.equals(conceptDto.getHasLink())) { |
Member
There was a problem hiding this comment.
Mettre dans une méthode conceptDto.hasLink() : plus lisible
| List<ConceptDTO> listConceptDTOsWithLinks = listConceptDTOs.stream() | ||
| .map(conceptDto -> { | ||
| if (Boolean.TRUE.equals(conceptDto.getHasLink())) { | ||
| List<NearbyConcept> nearbyConceptList = requestProcessor.queryToFindNearbyConcepts() |
Member
There was a problem hiding this comment.
mettre dans une méthode à part
FBibonne
reviewed
Mar 30, 2026
| .map(ConceptDTO::transformDTOenDefinition) | ||
| List<ConceptDTO> listConceptDTOsWithLinks = listConceptDTOs.stream() | ||
| .map(conceptDto -> { | ||
| if (getHasLink(conceptDto)) { |
Member
There was a problem hiding this comment.
if (conceptDto.hasLink()) et éviter de renvoyer un un objet Boolean pour éviter les NullPointerException lors de l'unboxing
Contributor
Author
There was a problem hiding this comment.
j'ai push une proposition, est-ce ce que tu attendais ?
FBibonne
approved these changes
Apr 1, 2026
GtanSndil
merged commit 58769dc
into
refactor/refactoring_magma_traditional_in_new_magma
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.