R repositories : moving to "/bin/linux"-style URLs when using PACKAGE_MANAGER_URL#330
Merged
phlg merged 2 commits intoInseeFrLab:mainfrom Dec 10, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Here's a PR to tweak the behavior of
onyxia-set-repositories.shregarding R repositories specifically. Namely, the intent is replace the/__linux__/style URLs with the/bin/linux, as this allows for better management when using third-party internal repositories (for instance, Sonatype Nexus). For more info on Linux binary resolution on Posit Package Manager, see this link.To explain in detail, when using the former style, it's necessary to use one Nexus repository per major.minor version of R (as we need to set the User-Agent matching the R version on a per-repository basis - even if the agent is set on the R client side, it's lost when Nexus tries to proxy Posit Package Manager). When using the latter style, we can use just one Nexus repository to proxy all the different architectures (both in terms of versions of R and Linux distributions).
But as simple as the change is, it might be a breaking change in its current state, for two reasons :
/__linux__/style URL here. This is probably desirable for users not using an internal repository, and assuming we should leave this untouched, we then have to "reset" this when actually using thePACKAGE_MANAGER_URL- this PR is implemented as such, but this is a new behavior which might lead to regression for some users (I can't see any obvious use case, but that doesn't mean there isn't any).PACKAGE_MANAGER_URLvariable would need to change the value for that variable. Pre-PR, the value could have been something likehttps://mypackagemanager.domain.com/r-packages/__linux__, but if the PR is accepted as is, the value would need to change tohttps://mypackagemanager.domain.com/r-packagesAs such, any suggestion that could transform this in a non-breaking change is more than welcome. Or otherwise, this PR can also be closed, we can still implement the necessary changes on our in-house rebuild of the images.
Thanks !